feat: Added Controller Methods for making DockerImage and Downloading Files #25
Conversation
kunxl-gg
commented
Oct 20, 2023
kunxl-gg
commented
- Wrote method for making DockerImage
- Wrote method for Downloading files
Signed-off-by: kunxl-gg <tiwari.25@iitj.ac.in>
Signed-off-by: kunxl-gg <tiwari.25@iitj.ac.in>
Signed-off-by: kunxl-gg <tiwari.25@iitj.ac.in>
Signed-off-by: kunxl-gg <tiwari.25@iitj.ac.in>
Signed-off-by: kunxl-gg <tiwari.25@iitj.ac.in>
Signed-off-by: kunxl-gg <tiwari.25@iitj.ac.in>
Signed-off-by: kunxl-gg <tiwari.25@iitj.ac.in>
Signed-off-by: kunxl-gg <tiwari.25@iitj.ac.in>
Signed-off-by: kunxl-gg <tiwari.25@iitj.ac.in>
Signed-off-by: kunxl-gg <tiwari.25@iitj.ac.in>
Signed-off-by: kunxl-gg <tiwari.25@iitj.ac.in>
TarunTomar122
requested review from
rohansingh9001 and
TarunTomar122
and removed request for
rohansingh9001
| } | ||
|
|
||
| // Build an image from a Dockerfile in the current directory | ||
| buildcontext, err := os.Open("./model.tar") |
There was a problem hiding this comment.
wasn't the files zip?
There was a problem hiding this comment.
We need to unzip and add the Dockerfile inside. I just made a tar after adding the Dockerfile.
There was a problem hiding this comment.
where are we adding the docker image and getting the tar file?
| @@ -2,32 +2,48 @@ module github.com/LainForge/Neura-Launch-Dashboard/builder | |||
|
|
|||
| go 1.21 | |||
There was a problem hiding this comment.
When did this happen
| return nil | ||
|
|
||
| } | ||
|
|
||
|
|
||
| func downloadFilesController(context *gin.Context) { |
There was a problem hiding this comment.
Why do we have the downloadFilesController ?
| Bucket: aws.String(config.AWSS3Bucket), | ||
| Key: aws.String("test.txt"), | ||
| } |
There was a problem hiding this comment.
im curious abt how this works... why "test.txt" ?
| r.GET("/downloadFiles", nil) | ||
| r.GET("/buildImage", nil) |
There was a problem hiding this comment.
what's this for ? r.GET("/downloadFiles", nil)
| } | ||
|
|
||
| // Build an image from a Dockerfile in the current directory | ||
| buildcontext, err := os.Open("./model.tar") |
There was a problem hiding this comment.
where are we adding the docker image and getting the tar file?
| // Starting the server | ||
| r.Run(":6969") |
There was a problem hiding this comment.
if u ever change the port here then make the necessary updates in dev, prod docker files and the dev, prod compose files. right now the docker-compose.yaml and builder.Dockerfile still exposes 5000. update that
